Hook refactor for ValidateLoginPage/index.js #19906

cristipaval · 2023-05-31T20:24:19Z

Details

!!! This is applicable only for iOS and Android native.

Fixed Issues

$ #16253

Tests

Note: I used this SO to test deep linking in dev

Sign in using the magic link with an account with 2fa enabled
Verify that the tab open by the magic link works as usual
Repeat the steps 1-2 with an account with 2fa disabled

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

N/A

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

N/A

iOS

Android

melvin-bot · 2023-05-31T20:24:52Z

@parasharrajat @marcaaron One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcaaron

Changes look good to me. But the linter will fail on warnings so we have to do something about the empty dependency array. I don't really see a problem with adding a comment and disabling the rule if there is a good reason to not include dependencies.

marcaaron · 2023-06-02T01:59:53Z

@cristipaval did @parasharrajat request to be unassigned from this one?

cristipaval · 2023-06-02T10:55:30Z

@cristipaval did @parasharrajat request to be unassigned from this one?

No, he didn't, I remembered that we ask for the C+ review only if we think it's necessary and I thought that this one is small 🤷
We can add him for more rigorous testing.

…alidateLoginPage-index

parasharrajat · 2023-06-09T01:45:28Z

!!! This is applicable only for iOS and Android native.

This is for web & Desktop.

src/pages/ValidateLoginPage/index.js

cristipaval · 2023-06-09T16:48:14Z

!!! This is applicable only for iOS and Android native.

This is for web & Desktop.

What do you mean? The implementation for the web is in ValidateLoginPage/index.website.js and for desktop this feature is disabled.

parasharrajat · 2023-06-09T17:32:36Z

The implementation for the web is in ValidateLoginPage/index.website.js

My bad. Search for native files and immediately jump to conclusions. You are correct.

…alidateLoginPage-index

cristipaval · 2023-06-09T18:18:37Z

Ready for a new round of reviews @parasharrajat @marcaaron

src/pages/ValidateLoginPage/index.js

cristipaval · 2023-06-12T19:48:10Z

@parasharrajat ready for review again

src/pages/ValidateLoginPage/index.js

parasharrajat · 2023-06-13T17:39:50Z

Thanks. On my list and will be completing it today.

parasharrajat · 2023-06-13T23:00:18Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-06-14.at.4.41.28.AM.mov

Screen.Recording.2023-06-14.at.4.49.53.AM.mov

🔲 Android / native

Screen.Recording.2023-06-14.at.4.45.07.AM.mov

Screen.Recording.2023-06-14.at.4.48.41.AM.mov

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

cc: @marcaaron

🎀 👀 🎀 C+ reviewed

parasharrajat · 2023-06-13T23:24:50Z

We can't merge this PR currently. The main PR which added usePermissions and useLocalize has been reverted #19498. But It will be implemented back with a regression fix thus we should wait here.

So we should hold on #20708

marcaaron · 2023-06-20T01:21:32Z

Are we still holding? If so, can we put a HOLD in the title @cristipaval ?

cristipaval · 2023-06-20T19:47:15Z

Are we still holding? If so, can we put a HOLD in the title @cristipaval ?

Good point. Thanks!

marcaaron · 2023-07-03T17:58:08Z

Looks like we are still holding here?

parasharrajat · 2023-07-03T18:19:17Z

We are good to proceed here. #20708 is merged.

cristipaval · 2023-07-04T11:08:48Z

On you @marcaaron

parasharrajat · 2023-07-04T14:22:15Z

src/pages/ValidateLoginPage/index.js

-    render() {
-        return <FullScreenLoadingIndicator />;
-    }
+    return <FullScreenLoadingIndicator />;
 }

 ValidateLoginPage.propTypes = propTypes;
 ValidateLoginPage.defaultProps = defaultProps;


Missing displayName

Let's add it

marcaaron

Looks clean! Great work. After we address Rajat's comment I am ready to merge. 🚀

marcaaron · 2023-07-04T19:40:14Z

src/pages/ValidateLoginPage/index.js

-    render() {
-        return <FullScreenLoadingIndicator />;
-    }
+    return <FullScreenLoadingIndicator />;
 }

 ValidateLoginPage.propTypes = propTypes;
 ValidateLoginPage.defaultProps = defaultProps;


Let's add it

cristipaval · 2023-07-05T10:24:09Z

@marcaaron, displayName is now added

OSBotify · 2023-07-05T18:08:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-07T10:46:06Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-11T00:01:08Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Hook refactor for ValidateLoginPage/index.js

453f0eb

cristipaval requested a review from a team as a code owner May 31, 2023 20:24

cristipaval self-assigned this May 31, 2023

melvin-bot bot requested review from marcaaron and removed request for a team May 31, 2023 20:24

melvin-bot bot requested a review from parasharrajat May 31, 2023 20:24

cristipaval removed the request for review from parasharrajat May 31, 2023 20:25

marcaaron requested changes Jun 2, 2023

View reviewed changes

cristipaval added 2 commits June 8, 2023 23:52

Merge remote-tracking branch 'origin/main' into cristi_hookrefactor-V…

5057c50

…alidateLoginPage-index

disable the rule for lint.

69538e8

cristipaval requested review from parasharrajat and marcaaron June 8, 2023 20:56

cristipaval changed the title ~~[HOLD] Hook refactor for ValidateLoginPage/index.js~~ Hook refactor for ValidateLoginPage/index.js Jun 8, 2023

parasharrajat reviewed Jun 9, 2023

View reviewed changes

src/pages/ValidateLoginPage/index.js Show resolved Hide resolved

cristipaval added 3 commits June 9, 2023 21:02

usePermissions custom hook

b47023e

Merge remote-tracking branch 'origin/main' into cristi_hookrefactor-V…

bc1aa1b

…alidateLoginPage-index

Remove withLocalize

9c177e5

cristipaval requested a review from parasharrajat June 9, 2023 18:18

cristipaval added 2 commits June 9, 2023 22:08

Make Lint happy

707161f

I hate you Lint

b3b7cf0

parasharrajat reviewed Jun 10, 2023

View reviewed changes

src/pages/ValidateLoginPage/index.js Outdated Show resolved Hide resolved

useLocalize hook to get preferredLocale value

1ab85df

cristipaval requested a review from parasharrajat June 12, 2023 19:48

parasharrajat reviewed Jun 12, 2023

View reviewed changes

src/pages/ValidateLoginPage/index.js Outdated Show resolved Hide resolved

Make Lint happy again

524f838

cristipaval requested a review from parasharrajat June 13, 2023 17:39

parasharrajat approved these changes Jun 13, 2023

View reviewed changes

cristipaval changed the title ~~Hook refactor for ValidateLoginPage/index.js~~ [HOLD] Hook refactor for ValidateLoginPage/index.js Jun 20, 2023

cristipaval changed the title ~~[HOLD] Hook refactor for ValidateLoginPage/index.js~~ Hook refactor for ValidateLoginPage/index.js Jul 4, 2023

parasharrajat reviewed Jul 4, 2023

View reviewed changes

marcaaron requested changes Jul 4, 2023

View reviewed changes

Add displayName

2f02364

cristipaval requested a review from marcaaron July 5, 2023 10:23

marcaaron approved these changes Jul 5, 2023

View reviewed changes

marcaaron merged commit 7036597 into main Jul 5, 2023

marcaaron deleted the cristi_hookrefactor-ValidateLoginPage-index branch July 5, 2023 18:01

OSBotify mentioned this pull request Jul 7, 2023

Deploy Checklist: New Expensify 2023-07-07 #22399

Closed

64 tasks

melvin-bot bot mentioned this pull request Jul 10, 2023

[HOLD for payment 2023-07-17] [$250] Migrate index.js to function component #16253

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hook refactor for ValidateLoginPage/index.js #19906

Hook refactor for ValidateLoginPage/index.js #19906

cristipaval commented May 31, 2023 •

edited

Loading

melvin-bot bot commented May 31, 2023

marcaaron left a comment

marcaaron commented Jun 2, 2023

cristipaval commented Jun 2, 2023

parasharrajat commented Jun 9, 2023 •

edited

Loading

cristipaval commented Jun 9, 2023

parasharrajat commented Jun 9, 2023

cristipaval commented Jun 9, 2023

cristipaval commented Jun 12, 2023

parasharrajat commented Jun 13, 2023

parasharrajat commented Jun 13, 2023 •

edited

Loading

parasharrajat left a comment

parasharrajat commented Jun 13, 2023 •

edited

Loading

marcaaron commented Jun 20, 2023

cristipaval commented Jun 20, 2023

marcaaron commented Jul 3, 2023

parasharrajat commented Jul 3, 2023

cristipaval commented Jul 4, 2023

parasharrajat Jul 4, 2023

marcaaron Jul 4, 2023

marcaaron left a comment

marcaaron Jul 4, 2023

cristipaval commented Jul 5, 2023

OSBotify commented Jul 5, 2023

OSBotify commented Jul 7, 2023

OSBotify commented Jul 11, 2023

Hook refactor for ValidateLoginPage/index.js #19906

Hook refactor for ValidateLoginPage/index.js #19906

Conversation

cristipaval commented May 31, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 31, 2023

marcaaron left a comment

Choose a reason for hiding this comment

marcaaron commented Jun 2, 2023

cristipaval commented Jun 2, 2023

parasharrajat commented Jun 9, 2023 • edited Loading

cristipaval commented Jun 9, 2023

parasharrajat commented Jun 9, 2023

cristipaval commented Jun 9, 2023

cristipaval commented Jun 12, 2023

parasharrajat commented Jun 13, 2023

parasharrajat commented Jun 13, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

parasharrajat commented Jun 13, 2023 • edited Loading

marcaaron commented Jun 20, 2023

cristipaval commented Jun 20, 2023

marcaaron commented Jul 3, 2023

parasharrajat commented Jul 3, 2023

cristipaval commented Jul 4, 2023

parasharrajat Jul 4, 2023

Choose a reason for hiding this comment

marcaaron Jul 4, 2023

Choose a reason for hiding this comment

marcaaron left a comment

Choose a reason for hiding this comment

marcaaron Jul 4, 2023

Choose a reason for hiding this comment

cristipaval commented Jul 5, 2023

OSBotify commented Jul 5, 2023

OSBotify commented Jul 7, 2023

OSBotify commented Jul 11, 2023

cristipaval commented May 31, 2023 •

edited

Loading

parasharrajat commented Jun 9, 2023 •

edited

Loading

parasharrajat commented Jun 13, 2023 •

edited

Loading

parasharrajat commented Jun 13, 2023 •

edited

Loading